Reduce time and errors on photo uploads

[VirginiaDooley]

Ref https://app.asana.com/0/1204880927741389/1207101641238151/f These changes are aimed at speeding up the photo upload process.

• removes the rotate functionality from the save method on the upload form
• moves the rotation to a renamed management command that processes moderation queue images, including running facial recognition

• runs the job every minute

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1207101641238151

[symroe]

I don't think this is going to solve anything, and in fact I think it will case more problems.

We can upload images larger than 1mb, and there are many uploads that are larger than this in the system (most, in fact, so I think this basically disables uploads).

The problem is somewhere around converting the image to png or rotating it. It might be a simple timeout in gunicorn. I don't know the details, but the solution will look like doing that work outside of the main upload process I expect.

[symroe]

TBH I don't think this is important enough to work on today. We can ask people to email us if something breaks, I guess?

[VirginiaDooley]

I don't think this is going to solve anything, and in fact I think it will case more problems.

We can upload images larger than 1mb, and there are many uploads that are larger than this in the system (most, in fact, so I think this basically disables uploads).

The problem is somewhere around converting the image to png or rotating it. It might be a simple timeout in gunicorn. I don't know the details, but the solution will look like doing that work outside of the main upload process I expect.

Ok, understood about 1MB, but we aren't limiting upload size at all. I'll look further into the

I don't think this is going to solve anything, and in fact I think it will case more problems.

We can upload images larger than 1mb, and there are many uploads that are larger than this in the system (most, in fact, so I think this basically disables uploads).

The problem is somewhere around converting the image to png or rotating it. It might be a simple timeout in gunicorn. I don't know the details, but the solution will look like doing that work outside of the main upload process I expect.

At the moment, we aren't capping the photo size for uploads at all, so even if just for storage costs, maybe we want to add a max that seems reasonable.

After further testing, you're right - the rotate_image step is taking way too long, even when it's not needed. I see if there is a way to speed it up when rotation isn't needed.