search

DemocracyClub / yournextrepresentative

👥 A website for crowd-sourcing structured election candidate data
https://candidates.democracyclub.org.uk
GNU Affero General Public License v3.0
21 stars 27 forks source link

Upcoming elections table shows number of candidates per election, not per ward #531

Closed sjorford closed 6 years ago

sjorford commented 6 years ago

e.g. the two Basildon by-elections have 4 and 3 candidates respectively, but the table shows 7 each:

image

Possibly related: the links in both the Election and Area columns go to the /constituencies page - the latter should go to the /post page

chris48s commented 6 years ago

I expect I want to wait until the work on the 2018-refactor branch hits master before looking at this one otherwise we'll end up fixing the same bug twice.

/remind @chris48s ping in 2 weeks

reminders[bot] commented 6 years ago

@chris48s set a reminder for Jul 2nd 2018

reminders[bot] commented 6 years ago

:wave: @chris48s, ping

chris48s commented 6 years ago

I put this off for ages because we were moving so much about. Finally went to reproduce it today and it works fine now:

screenshot at 2018-09-28 16-23-50

I reckon this got fixed somewhere in the depths of https://github.com/DemocracyClub/yournextrepresentative/commit/7054bcb5c41a911091cded02dbe60ec56603b4e4

I've submitted #657 to change the link target on the post. Do re-open or raise another issue if this happens again.