Update generic reports with IRV winners; integrate IRV into existing reports - Githubissues

DemocracyDevelopers / colorado-rla

Colorado Risk-Limiting Audit (RLA) software – developed to support risk-limiting post-election audits of election outcomes.

Other

0 stars 0 forks source link

Update generic reports with IRV winners; integrate IRV into existing reports #137

Closed vteague closed 3 months ago

vteague commented 5 months ago

Depends on #136

ReportRows::genSumResultsReport currently calls ContestResult::getWinners to get the winner - update it to use the IRV winners table (or errors) instead.

vteague commented 3 months ago

genSumResultsReport() was already updated in #136.

vteague commented 3 months ago

First pass at what may need updating, from resources/SQL:

auditboard.sql - no update.
batch_count_comparison.sql - no update.
contest.sql - no update.
contest_comparison.sql - update with invalid IRV ballots pre-interpretation.
contest_selection.sql - no change.
contests_by_county.sql - no change.
ranked_ballot_interpretation.sql - new, specific to IRV.
seed.sql - no change.
tabulate.sql - restrict to plurality only.
** add a new one that "tabulates" IRV by just pulling the GenerateAssertionSummaries.
tabulate_county.sql - restrict to plurality only.
upload_status.sql - no change.
ActivityReport.xls - no change.

vteague commented 3 months ago

Also update state-general... .xlsx to have proper IRV data when IRV contests are audited.

vteague commented 3 months ago

Correct summary table of Results report - get margin and diluted margin from IRVComparisonAudit, not ContestResult.
Check with CDOS what they'd like the Summary of state-general...xlsx to look like for IRV.

vteague commented 3 months ago

Check discrepancy in ActivityReport.xls.
min margin and diluted margin in ResultsReport, in county-specific sheets as well as in summary.
discrepancies in ResultsReport, in both the summary and the individual ones.

vteague commented 3 months ago

Min margin in ResultsReport is certainly wrong. Boulder Mayoral should be 1228.

vteague commented 3 months ago

Maybe we should add "risk limit met Y/N" to the assertions csv.

vteague commented 3 months ago

Decisions:

Discrepancies seem OK after a cursory check. Need more complete testing.
In the ResultsReport and state reports, decided to just omit everything but the contest name and the list of choices. All the necessary data (who won, the margins, etc), are in the IRV-specific reports anyway.