IRV ballot classes - Githubissues

DemocracyDevelopers / colorado-rla

Colorado Risk-Limiting Audit (RLA) software – developed to support risk-limiting post-election audits of election outcomes.

Other

0 stars 0 forks source link

IRV ballot classes #77

Closed vteague closed 5 months ago

vteague commented 5 months ago

Implement IRVPreference, IRVChoices and IRVBallotInterpretation, including tests. For these classes, it is acceptable to re-use the code already written in the prototype, because it already has extensive test cases and has been reviewed by both @michelleblom and Lillian McCann. However, the commenting could be improved.

vteague commented 5 months ago

Some simplifications:

InterpretValidIntent() makes a lot more sense as a method of IRVChoices than a static method of IRVBallotInterpretation (which it was in the prototype).
InterpretValidIntent is never actually called in the prototype except to immediately call .AsSortedList, so I decided to put these into one function, GetValidIntent(), which returns the implied preference ordering as a sorted list of candidate names.

vteague commented 5 months ago

Note I haven't implemented IRVBallotInterpretation, which now will have only the database record and hence possibly deserves a different name. I have, however, implemented all the actual IRV ballot interpretation, including validity testing and the application of validity rules from the statute.

vteague commented 5 months ago

Addressed by PR #101.

vteague commented 5 months ago

Closed by #101