DemocracyEarth / old_dapp

Liquid democracy smart contract implementation
32 stars 13 forks source link

signup front end integration #45

Closed virgile-dev closed 6 years ago

virgile-dev commented 6 years ago
virgile-dev commented 6 years ago

Signup page:

capture d ecran 2018-04-22 a 12 14 24
aecc commented 6 years ago

@LucasIsasmendi why is this closed? This is still missing:

  1. "You are in view mode": Sign up button. Mine says "profile" for some reason.
  2. "Please install Metamask" is missing
  3. It shows full screen, is that intended?
LucasIsasmendi commented 6 years ago

@aecc

  1. Was closed because we can not apply the same concept of sign up in a blockchain dapp, the smart contract is open to everyone. Also we are relying on email, something that we can't validate: how validate the ownership of the email that was stored into IPFS through the smart contract?. A solution is to use a generic field of 30 chars to store any user information That was the main reason to switch to profile. We need to discuss this in a new issue.
  2. Yes, adding that one.
  3. The idea is work with css, no angular material design, @AlexJupiter will be doing that UI part
aecc commented 6 years ago
  1. I understand there is no validation to do, however the voters do need to sign up to the contract to be able to interact with it by calling the blockchain registerNewVoter() function. Besides, the sign up button gives a familiar and "skeuomorph" sense to what the user must do before being able to interact. I believe @AlexJupiter might agree on that.

If you think that we should split this task in multiple others ("Please install Metamask", user validation, fullscreen, etc) feel free to do it. However I'm a fan of having everything written down on github issues so we can really understand what is missing and what we need to work on. So if we close this issue let's create others that reflect what we will do.

LucasIsasmendi commented 6 years ago

In the smart contract you can createNewBallot() without registerNewVoter(), so there is no user validation in the backend. Will we change this in the future? Also email verification is a process of 3 steps: you get the user email, send a token validation to the email account and then you validate the user when clicks in the token. We don't have that in blockchain space since key pair is the user identity

aecc commented 6 years ago

Yes, there needs to be validation for creating a new Ballot, it's actaully commented out with a TODO. We commented it for hackaton purposes. If we cannot do this type of validation, I propose to skip the validation topic for a discussion in another issue and leave the signup form to add a name and register yourself as a voter

LucasIsasmendi commented 6 years ago

Perfect, I will add that validation again and use only to register yourself