DemocracyEarth / old_dapp

Liquid democracy smart contract implementation
32 stars 13 forks source link

Style ballot dashboard page #49

Open virgile-dev opened 6 years ago

virgile-dev commented 6 years ago

Parent #69

THE BALLOT

YOUR ACTION

LIQUID DEMOCRACY REPRESENTATION

See #57 for delegate tab.

virgile-dev commented 6 years ago

Vote on ballot

capture d ecran 2018-04-22 a 15 25 02

Revoke delegation on ballot

capture d ecran 2018-04-22 a 15 21 16
AlexJupiter commented 6 years ago

New designs for this: https://www.figma.com/file/Eo76kM4frkNFRBjvtvGKCNqc/Sovereign-UI-toolkit?node-id=846%3A0

image

aecc commented 6 years ago

Looks amazing

AlexJupiter commented 6 years ago

@LucasIsasmendi now I've made progress with the design system, I'll be able to crack on with some of these points above this week. Are the above completed/in-completed tasks above still accurate with your side?

AlexJupiter commented 6 years ago

@LucasIsasmendi do you know why the active tab state isn't working?

LucasIsasmendi commented 6 years ago

No idea, we need more front end power

medied commented 6 years ago

@AlexJupiter @LucasIsasmendi could you guys elaborate on the issue here? Trying to debug

AlexJupiter commented 6 years ago

@medied are you are to click on the delegates tab, on the ballot dashboard, to see the list of delegates?

When I click on "delegate" this is the error I see: image

medied commented 6 years ago

@AlexJupiter was able to replicate that tab behavior and fixed it with c8b2e1a630a8d1e92d16660919487168ac42f875. Looks like it was originally set correctly with 35fba64ed8617cccab68ee366d4feaa4b6e626ee but got messed up with 3c3eb12d930941928163723b6a051c6c7bb30587.

Does this resolve the blocker for you? Seems there are some thing things that are still broken with ballot-dashboard but I'm actually not sure because I'm likely out of context. Let me know though, if there are more bugs indeed we should list them out as separate issues. Thinking we could probably benefit from a brief 15-minute video call with @LucasIsasmendi just to sort this stuff out.

AlexJupiter commented 6 years ago

@medied apologies about the delayed reply, however I think I said this in the catchup on Monday, you've resolved my blockers. So thank you!

AlexJupiter commented 6 years ago

@medied I'm also struggling with https://github.com/DemocracyEarth/dapp/issues/95 that needs to be completed for this issue to be closed. Would you be able to help me with this?

medied commented 6 years ago

Low on bandwidth this week