Open virgile-dev opened 6 years ago
The ballot page when just created:
If the proposed changes are implemented in https://github.com/DemocracyEarth/contracts/issues/51 I think this issue is redundant right?
Still the we need to implement fetching title, author, date from the blockchain. I'll be working on this soon
title, author and date are not coming from IPFS?
yes, I meant from IPFS, through the blockchain first. As I see only author name is missing. The rest, title and date seem implemented
@aecc @LucasIsasmendi there seem to be some duplicates of the points here in https://github.com/DemocracyEarth/dapp/issues/49, should this issue be closed and we just refer to #49 ?
Also, is this in "in progress", and if so, which one of you is working on this?
There is a pending "author name" implementation, the trick here is if we should rely on IPFS or ETH for that. But yes, we can close this because we changed the view model of this ballot detail page
@AlexJupiter @LucasIsasmendi I thought the #49 was a pure UI or UX task. There is work to do about the author unrelated to UX. @LucasIsasmendi as you already closed the issue, wanna add it somewhere else so it's not forgotten?
You are right @aecc , reopening this to complete pending task
Ballot information that we need to query:
The transaction status is only needed when the user creates the ballot. I'm thinking to construct the page we don't really have to get title, author name, date of creation if we just cache them and construct the page with the info. That way the only getter we'd need would be the transaction status. What do you think @LucasIsasmendi @aecc ?