Closed aecc closed 6 years ago
@aecc @LucasIsasmendi can someone provide me with more context on LiquidDemocracy.json
and Migrations.json
(both under /dApp-Srv-Exp/contracts
)?
I see that they're basically the ABI but want to understand how they fit into code structure under dApp-Srv-Exp
and root /contracts
overall.
In PRs like this one the diffs are huge (+11,777 −8,139
) because of the json files, assuming they can't be added to .gitignore
Yes, we are adding that files to .gitignore, in the future all local runs should compile the contract
Also we should improve ipfs files, they are more than 3MB each, is a lot for a min file.
@LucasIsasmendi the old ipfs js it's not used anymore. However I recommend not to remove it if we are going for a local + remote approach on IPFS nodes.
@medied I think @LucasIsasmendi already mentioned most of it. But something to add: json files are compiled .sol contracts (using truffle) meant to be understood by web3 (web3 will take care of api calls to the blockchain using the APIs compiled in the jsons). Also, because of limitations/bugs in truffle we need to copy them from /contracs/build/ to /dApp-Srv-Exp/contracts. /contracs/build/ is ignored, but /dApp-Srv-Exp/contracts not. Basically because I wanted to have the "deployed" contracts somewhere saved. But because there is no way to redeploy a contract without changing it. It's probably just better to store it in the place where we deploy it from (like heroku)
Okay this is useful context, thank you!
Fixes (2) in #54
Graph is visualized correctly.
Some restrictions:
In order for this PR to work correctly #74 needs to be merged firstWe probably need to have some discussions about the data models. To allow multiple ballots to work correctly and efficiently
Current screenshot: