search

DemocracyLab / CivicTechExchange

https://www.democracylab.org
MIT License
97 stars 64 forks source link

Add unit test precheck to PR's #1073

Open hyihua opened 10 months ago

hyihua commented 10 months ago

This pull request is to address the issue #1055, which includes unit tests for python files and for JavaScript files.

qchiujunhao commented 9 months ago

@marlonkeating this PR is ready for review. The python unittest failed but not because of this PR. The only passed check in this PR could be the testing reference(SHA: ec06d1b) for reviewing. So we created a new issue #1078 for the failed python unittest. They can be resolved separately.

qchiujunhao commented 8 months ago

Adding more description here for better review -- The only passed check ec06d1b was because we removed python unit test to only run javascript tests. And it proves the changes on github actions are good to merge. But because #1078, the python unit test failed, which has nothing to do with this PR.