search

DemocracyOS / config

Node configuration json files loader. Overrideable by environment variables. Very opinionated.
MIT License
6 stars 1 forks source link

Environment variables scoped under 's3' are not working #2

Closed mjlescano closed 7 years ago

mjlescano commented 8 years ago

e.g.: defaults.json

{
  "s3": {
    "bucket": "bucke-name"
  }
}

If I try to set it via S3_BUCKET doesn't work.

gvilarino commented 8 years ago

Any insights as to why?

gvilarino commented 8 years ago

I've confirme this doesn't work also with a value like url2png. The symptom feels like "if there's a number in the name, I won't work".

gvilarino commented 8 years ago

This probably seems like it: https://github.com/blakeembrey/no-case/pull/7

@mjlescano can you please release a new version of dos-config with change-case@3.0.0?

Make sure our tests by @franciclo pass before releasing, and add a test for a setting like s3endpoint or anything with a number in it.

gvilarino commented 7 years ago

:+1: