search

DemonBoiAnzu / ItemQualities

A plugin that adds Qualities to Items, along with the ability for the user to create their own.
MIT License
10 stars 3 forks source link

BUG - Quality Items removing everything except it self from the items. Vanilla Enchantments seem to be excluded. #18

Closed Zhaaaaaaaaa closed 2 years ago

Zhaaaaaaaaa commented 2 years ago

Describe the bug - Please describe CLEARLY what went wrong.

Installing this plugin. Successfully Installed. version 1.1.0

Any item taken out of Creative or Crafted Adds the random Quality like it is supposed to.

It messes up any other Plugin. Whether it is Enchantments, Lore Name or Lore Description.

Most Noticeable with Tridents and Elytras since they sort of 'reload' or something during / after use.

Adding such modified items into something like Shopkeeper resets the item into a Item Quality (removes all lore, enchantments etc.) and creates a duplicate. (not an issue if you're in staff mode doing staff stuff. but thought I should mention this if it has useful info to it.)

To Reproduce - Please describe the steps you took to have this issue occur, if any. As explained above, basicly.

Expected behavior - Please describe the behavior you expected. As explained above, basicly.

Screenshots - Provide any applicable screenshots. Unnecessary.

Server Information - Please provide your server version, server build version (e.g paper 1.18.2 build #100) Paper 1.18.1 AND Paper 1.18.2 that I upgraded to. 'This server is running Paper version git-Paper-387 (MC: 1.18.2) (Implementing API version 1.18.2-R0.1-SNAPSHOT (Git:df630a2 on ver/1.18.2) Previous version: git-Paper-216 (MC:1.18.1)

Additional context - Please describe any additional information CLEARLY here. Plugins I'm using that seem to be interfering CrazyEnchantments CrazyEnchantments - Its GUI (Althought I suspect it is the Author of Crazy Enchantment's fault as Jobs GUI is not bothered by your plugin) LoreAttributesRecorded

Plugins I suspect may have difficulties with your Plugin but I have not tested it out properly, if you would, by any chance like me to do so... here is my discord: ★ Zhaaaaaaaaa ★#1533

I'm pretty sure you can pretty much ignore this list until reports are made

Shopkeepers <- the glitch as mentioned above in "Describe Bug" section Angelchest <- might do the reset bug ExecutableItems (Free version) <- Have not tested as I'm overloaded with other things, but I can. or I'll just report it seperately. Jobs <- Items bought from its Shop <- same thing, not tested yet. RoseStacker <- Items bought from its Shop <- same thing, not tested yet. PlayerAuctions <- Items bought from its Shop <- same thing, not tested yet.

Additionally, I would just like to thank you for your plugin. Nice work and I'll be adding some suggestions sometime later. Also sorry if my report was very cluttered or badly written.

DemonBoiAnzu commented 2 years ago

Sounds more like these plugins reset the item, I have absolutely no idea how mine would be causing a reset of the item.

As for lore added by other plugins disappearing, I'm working on a fix for that, as that is caused by mine.

DemonBoiAnzu commented 2 years ago

There really is no way of properly fixing this. Nothing I can do about problems caused by other plugins, honestly.

DemonBoiAnzu commented 2 years ago

Oh, also, this appears to be a duplicate of #16, more or less. While yours isn't specifically about custom enchantments, both are the same issue. I will be closing this one. If you have more to say, please comment on #16 or make another issue (if it's not another duplicate)