search

DemonBoiAnzu / ItemQualities

A plugin that adds Qualities to Items, along with the ability for the user to create their own.
MIT License
10 stars 2 forks source link

Netherite Items are not changing #3

Closed DerMFMonix closed 2 years ago

DerMFMonix commented 2 years ago

When crafting a netherite sword out of a diamond sword, the netherite sword will be exactly the same as the diamond sword. No new quality and even the damage will be the same as diamond.

DerMFMonix commented 2 years ago

2022-06-16_15 06 30

It keeps the same damage and the name from the old sword.

DerMFMonix commented 2 years ago

Found a new Bug, maybe. You can duplicate Armor when killing someone if he has a weapon with a DoubleDropChance. The Armor gets duplicated and stacked Bild_2022-06-16_181351766

DemonBoiAnzu commented 2 years ago

A complete oversight on my end! My bad, I'll get onto fixing it! Thanks for the reports!

DemonBoiAnzu commented 2 years ago

I believe I have fixed all of these issues, would you mind testing it?

Download the fix here.

Lemme know if everything is alright and I will publish it!

DerMFMonix commented 2 years ago

2022-06-16_22 50 47 2022-06-16_22 50 54

There is a new problem now, the new netherite sword doesn't get any attributes or a quality.

But the duplicating Bug is fixed now. The killed player doesn't drop his armor in duplicated stacks anymore. But I don't know if It only affects the player's wearing armor or his whole inventory (blocks, items, tools)

DemonBoiAnzu commented 2 years ago

It doesn't get a quality because you have the craft option disabled, if you enable it, it will get one. Technically smithing is crafting :p

DemonBoiAnzu commented 2 years ago

oh also, the double drops will effect anything that has a max stack size of more than 1 (so tools and such will not be effected) if you think I should make it to where the double drops only effects mobs, let me know!

Also, do you think I should make it to where if you have the quality on craft disabled when you smith, the result item should get the quality of the input item?

DerMFMonix commented 2 years ago

It would be nice if the double drops only affected the mobs, and your suggestion with the smith is also great. I would also like to suggest a reload feature if it isn't already implemented

DemonBoiAnzu commented 2 years ago

What do you mean reload feature? like a /reload command? There is one, /qualities reload

And alright, sounds good, I'll get those going.

DemonBoiAnzu commented 2 years ago

I got those suggestions in now. Test them out here.

Note, the double drop now only effects Mobs AND Animals. If you think I should add config options to better customize what it effects, let me know!

DemonBoiAnzu commented 2 years ago

I'm going to assume everything is in order, on my end everything is fine! thanks for reporting these issues. I will be publishing this hotfix now, you can get it here. You may reopen this issue if you have anything else to say!