DemoninCG / DodecaDragons

Grow your dragon, grow your empire!
MIT License
7 stars 5 forks source link

"multiply holy tetrahedron gain" #3

Open hvds opened 4 months ago

hvds commented 4 months ago

The second holy fire upgrade, "multiply holy tetrahedron gain", seems from the timing that it is reached within the game like it ought to affect the tetrahedrons gained from the 5th octahedron upgrade "gain 1 free tetrahedron per second". However from the code that does not seem to be the case - the effect of the latter is hard-coded to give 0.5 (presumably every 0.5 seconds), while the former appears to affect only tetrahedron resets and some much later-game achievement "Gain 100% of potential polyhedrons per second".

Since by the time you have holy fire you probably aren't doing tetrahedron resets any more, this all seems quite strange - unless the intention was for the 1/s upgrade to be affected instead, perhaps via a separate game.holyFirePerSecond variable.

Can you please clarify what the intention is here?

hvds commented 4 months ago

Since by the time you have holy fire you probably aren't doing tetrahedron resets any more

Ah, I guess this was my mistake: I hadn't seen anything implying that spare tetrahedrons gave any bonus, so had assumed there was no value trying to get more.

I do think it could be made clearer, somehow, that "multiply holy tetrahedron gain" is not intended to apply to the "gain 1 free tetrahedron per second" bonus.