Demonshaha / pe

0 stars 0 forks source link

Bugs after delete ID and then add another #1

Closed Demonshaha closed 2 years ago

Demonshaha commented 2 years ago

image.png after deleting ID 5, I immediately added a patient and then he becomes ID 5, as the notes in the UG, every patient has his or her specific ID, so this overlapped. Moreover, if this situation allows overlap, the new patient's ID should be 1, because the list is empty, should not be 5

nus-se-script commented 2 years ago

Team's Response

Since patient 5 has been deleted, there is no one with PATIENT_ID of 5. So it is perfectly fine to add a new patient to have an ID of 5. The purpose of the PATIENT_ID is to uniquely identify patients, so it doesn't matter whether the next PATIENT_ID is 1 or 5. But the reason as to why it was implemented such that the newly added patient has an ID of 5 and not 1 was so that the patients are listed in order of their addition into the list.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Because there isn't patient ID from 1-5, I think the new patient's ID should be 6 or be 1. Be five confuses user


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Because this would confuse user to manage and organise patients