Demonshaha / pe

0 stars 0 forks source link

Wrong exceptions generated #11

Open Demonshaha opened 2 years ago

Demonshaha commented 2 years ago

image.png The exception message should be exceed the largest capacity not "The capacity should be a postive number", it is clear that 999999999999999999999 is a positive number

nus-pe-script commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Inconsistent exception to same kind of exception

Screen Shot 2022-04-16 at 4.39.55 PM.png The same kind of invalid input(route of index not exists), but getting different exception message. The second exception message should be undefined behavior. Moreover, there is actually a bound of number of routes in the app, which is 2147483647, because the previous inconsistent exception message reflects that the data type used to storing the number of routes is an "int", which has naturally bound 2147483647. Without declaration, the records will be overwritten when the number of routes exceeds 2147483647.


[original: nus-cs2113-AY2122S2/pe-interim#1311] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for reporting it.

This problem of integer overflow can only happen in case of deliberate sabotage. The app does not crash and the input is not accepted. Thus the data will not be corrupted. Therefore, we think that it is more reasonable to be a low severity bug.

This is consistent with the specification on module website:

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]