search

Demonware / jose

Python implementation of the Javascript Object Signing and Encryption (JOSE) framework (https://datatracker.ietf.org/wg/jose/charter/)
BSD 3-Clause "New" or "Revised" License
95 stars 34 forks source link

Feature/py3k #2

Closed bwhmather closed 8 years ago

bwhmather commented 9 years ago

Have mostly adapted the jose package to work with python 3 (in addition to python 2).
Getting tests running with multiple versions of python has necessitated rearanging some of the files but I believe that I have managed to avoid breaking the current api.

There is one remaining problem which is that I can't figure out what format the key for hmac algorithms should be in and therefore whether, and where, it should be encoded as bytes or unicode. Will have another look at fixing it now. This problem does not affect python 2 however.

I do have to say that the excellent test suite has made this really quite easy. Thank you.

demianbrecht commented 9 years ago

Hi @bwhmather, thanks for the contribution. I'm sure making this 2/3 compatible had some headaches associated with it :)

Unfortunately, things are rather slow at the moment during the holiday break, but we'll definitely do a thorough review early in the new year.

bwhmather commented 9 years ago

Thank you and no problem. I'm also working on another branch that replaces the JWA object with separate lookup functions for different algorithms that will hopefully be worth looking at when you have time. Merry Christmas

nmurtagh commented 8 years ago

Hi @bwhmather thanks for your work on this. I've opened a new PR #15 which provides Python 3 support using six.