DenVdmj / htmlcompressor

Automatically exported from code.google.com/p/htmlcompressor
Apache License 2.0
0 stars 0 forks source link

YUI compressor version allowed should be up to 2.4.5 #31

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. If i build and i have yuicompressor-2.4.5.jar in the same folder as 
htmlcompressor-0.9.9.jar I get an error.

What is the expected output? What do you see instead?

I get this:

 [apply] ERROR: For JavaScript or CSS compression YUI compressor jar file 
    [apply] must be present in the same directory as HtmlCompressor jar
    [apply] Result: 1

Everything works fine with yuicompressor-2.4.2.jar

I suppose there is a max version set somewhere?

We are forced to upgrade because there is a bug in yuicompressor's css thing 
that makes this:

@media screen and (max-device-width: 480px){

into this

@media screen and(max-device-width: 480px){

But it turns out there is a webkit bug that tosses out the whole MQ if that 
space is not present before the (

And 2.4.2 has this bug.. (but I think its fixed as of 2.4.3.. definitely fixed 
in my recently built 2.4.5)

So I suppose this bug is also fair warning the htmlcompressor's built in CSS 
minifier may also have this bug.  :)

Original issue reported on code.google.com by paul.ir...@gmail.com on 23 Mar 2011 at 1:24

GoogleCodeExporter commented 8 years ago
Jar filenames are currently hardcoded to be yuicompressor-2.4.2.jar, 
yuicompressor-2.4.4.jar, yuicompressor.jar (limitation of command line jar 
execution afaik). I will add 2.4.5 to the list, but if you need this right away 
you can just rename your yui jar to yuicompressor.jar 

Where can I download 2.4.5 with the sources? I bundled YUI CSS compressor 
implementation into htmlcompressor v1.0, so I copied that bug as well...

Thanks.

Original comment by serg472@gmail.com on 23 Mar 2011 at 4:26

GoogleCodeExporter commented 8 years ago
Sorry, actually I think I added yuicompressor.jar filename only in v1.0. So you 
would need to rename that jar to either yuicompressor-2.4.2.jar or 
yuicompressor-2.4.4.jar

Original comment by serg472@gmail.com on 23 Mar 2011 at 4:35

GoogleCodeExporter commented 8 years ago
To build 2.4.5 I grabbed this source and ran Ant: 
https://github.com/yui/yuicompressor

And I've attached it here.

Original comment by paul.ir...@gmail.com on 25 Mar 2011 at 1:37

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks.

If you are following YUI development do you know how stable this build is? Is 
it safe to replace 2.4.2 that I pack with the compressor to 2.4.5?

Original comment by serg472@gmail.com on 25 Mar 2011 at 3:02

GoogleCodeExporter commented 8 years ago
OK I moved CSS compressor out of htmlcompressor again in 1.1 release, and made 
yui jar filename requirements to be anything yuicompressor-2.4.*.jar or 
yuicompressor.jar

Original comment by serg472@gmail.com on 26 Mar 2011 at 8:14

GoogleCodeExporter commented 8 years ago
Thanks! This is great. Worked like a charm.

Original comment by paul.ir...@gmail.com on 30 Mar 2011 at 11:45