3.0.7 does not compile on 32bit archs

[GoogleCodeExporter]

Dear Josh,

xdelta3 3.0.7 does not compile in 32bit architectures.

There are different issues, but it all boils down to the size of 'size_t'

See 
http://buildd.debian.org/status/package.php?p=xdelta3

for details

a.

Original issue reported on code.google.com by mennu...@debian.org on 12 Jun 2013 at 6:09

[GoogleCodeExporter]

hi,

the problem is that in 32bit architectures,  size_t is a 4byte quantity; 
whereas xdelta3.h defines at line 156
   typedef uint64_t xoff_t; 
then in testing/regtest.cc line 763 the line
   options.encode_srcwin_maxsz = 
    std::max(spec0.Size(), options.encode_srcwin_maxsz);
fails since it cannot write into a 'size_t' the maximum of a 'uint64_t' and a 
'size_t' quantity

Maybe the solution is to define
  uint64_t encode_srcwin_maxsz;
in regtest.cc at line 15 ; please confirm if this makes sense

a.

Original comment by mennu...@debian.org on 16 Jun 2013 at 9:16

Attachments:

• regtest_size_t

[GoogleCodeExporter]

hi,

after applying that patch, it compiled fine everywhere

https://buildd.debian.org/status/package.php?p=xdelta3&suite=sid

a.

Original comment by mennu...@debian.org on 18 Jun 2013 at 7:46

[GoogleCodeExporter]

Yes, it allows again the build, thanks.

There are other warnings in the regtest.cc file.  Log attached.

Original comment by pa...@raiskup.cz on 18 Jun 2013 at 1:11

Attachments:

• log

[GoogleCodeExporter]

Sorry for the previous comment.  It is already mentioned in @162, damn.

[OT] Is there a way how to receive all tickets created on my email for this
project? [/OT]

Original comment by pa...@raiskup.cz on 18 Jun 2013 at 1:22