DendrouLab / panpipes-tutorials

tutorials to run panpipes
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Change ATAC normalization to TFIDF-signac in preprocess tutorial #44

Closed Lilly-May closed 8 months ago

Lilly-May commented 8 months ago

Previously, log1p normalization was used for the ATAC data in the preprocess tutorial. This raises downstream errors in both the clustering and the visualization pipelines, as those expect a signac_norm layer, which is created when using TFIDF normalization with flavor signac for ATAC normalization.

I decided to adapt the ATAC normalization in the preprocess step instead of in both downstream pipelines, but I'd love to hear opinions on whether this is the best way to resolve this issue.

Closes #26.