Added possiblity to map PS Button, Touchpad Button and Mic Button

Denellyne / PCXSense

Translates the inputs from the Dualsense into XInput making it compatible with any PC Game

MIT License

338 stars 9 forks source link

Added possiblity to map PS Button, Touchpad Button and Mic Button #11

Closed giacogiac closed 6 months ago

giacogiac commented 6 months ago

Added possiblity to map PS Button, Touchpad Button and Mic Button
Fixed parenthesis mistake for start and select press detection with mapping
Fixed a bug where mapping 2 buttons to the same button and pressing them at the same time would work incorrectly
Added Mic button visualisation in debugData
Cleaned visualisation of buttons press in debugData
Changed names of buttons in Mapping HMI to be more faithful to PCXSense behavior and names used in games : Playstation buttons are mapped on XBox buttons
Fixed HMI button "Create new trigger Profile" to more accurate "Create new Game Profile"

Tested on DualSense but not on DS4

Denellyne commented 6 months ago

Looks good ,haven't been home lately so I couldn't review it thoroughly,I'll probably get around to it tomorrow , also because I never merged a PR so im learning.

giacogiac commented 6 months ago

I rebased to your latest changes

Denellyne commented 6 months ago

Looks good the only thing i don't like is you renaming the variables specially when you abreviate ,everything else looks good ,need to test on the dualshock4 before merging and i qill revert the renaming of the variables,I'll also change the bluetooth variable to offset because its more descriptive of what it actually does

Denellyne commented 6 months ago

@giacogiac I removed the option to use the touchbutton because im pretty sure it will conflict with start/select as in,you will trigger Start/select at the same time you try to press the touchbutton which is not intended

giacogiac commented 6 months ago

I actually did all this work just for the touchbutton. Most playstation games use the touchbutton as the back button of xbox (opening map, etc..) while the share button on playstation is exclusively used for screenshots. I could simply gray out and disable the touchbutton if the start/select is checked.

Denellyne commented 6 months ago

I actually did all this work just for the touchbutton. Most playstation games use the touchbutton as the back button of xbox (opening map, etc..) while the share button on playstation is exclusively used for screenshots. I could simply gray out and disable the touchbutton if the start/select is checked.

Seems fair,don't worry about it i'll add it again then and fix a potential error you added,because you changed the order the button mapping goes it might be incompatible with previous versions