Denhac / denhac-webhooks

This repo holds some of our membership automation stuff. It listens to webhooks from the main wordpress site
7 stars 2 forks source link

[Slack][Equipment Authorization] Remove redundant empty form information #52

Closed chungl closed 5 months ago

chungl commented 5 months ago

This PR removes the "Please select at least one member..." and "Please select at least one piece of equipment..." These changes spawned from conversation in an earlier, unrelated pr.

The select fields are already required and come with built-in error messages that are shown on form submission and cleared on field change. This makes our custom warnings unnecessary.

This allows us to merge the setupModalCommon into the constructor.

Before:

Screenshot 2024-01-18 at 11 27 28 AM

After: Screenshot 2024-01-18 at 11 22 11 AM

Error Progression:

EquipAuthRemoveCopyErrorProgression

Jnesselr commented 5 months ago

Approving but if we don't have to handle this anymore, then neither the empty checks or those methods are required anymore, yeah?