DenisCarriere / geocoder-geojson

Geocoding results in GeoJSON format
https://www.npmjs.com/package/geocoder-geojson
MIT License
21 stars 10 forks source link

Locale ignored for google #10

Closed terry90 closed 7 years ago

terry90 commented 7 years ago

The response of this is in french (I am french, and so my browser settings)

  geocoder.google(address, { language: 'en' })
    .then(geojson => cb({ ...geojson, provider: 'google' }))
    .catch((err) => {
      console.warn(err);
    });
DenisCarriere commented 7 years ago

@terry90 Thanks for pointing that out, I just fixed it and published a new release.

Added these to the test cases.

https://github.com/DenisCarriere/geocoder-geojson/blob/master/test.ts#L10-L17

Next time provide the specific address you are referencing to.

terry90 commented 7 years ago

Yeah sorry, but it was not one address, that's why I did not precised one. 😄 Thanks for fixing this issue !

DenisCarriere commented 7 years ago

@terry90 No worries, it was clearly a bug :+1: Thanks for reporting it