search

DenisCarriere / geocoder

:earth_asia: Python Geocoder
http://geocoder.readthedocs.org
MIT License
1.63k stars 288 forks source link

Add What3Words as a provider #102

Closed DenisCarriere closed 9 years ago

DenisCarriere commented 9 years ago

URL Request http://api.what3words.com/w3w?key=API_KEY&string=footloose.sunburnt.tower

API Docs https://what3words.com/api/reference#m1

karanparikh commented 9 years ago

Is anyone working on this issue? If not I would like to contribute.

DenisCarriere commented 9 years ago

Hey Karan,

At the moment there isn't anyone working on it, I'm currently going down the list of issues and tackling them one by one.

If you want to send a Pull Request with your changes I will gladly accept it.

Thanks!

~~

Twitter: @DenisCarriere GitHub: DenisCarriere

On Sat, Feb 28, 2015 at 5:22 PM, Karan Parikh notifications@github.com wrote:

Is anyone working on this issue? If not I would like to contribute.

— Reply to this email directly or view it on GitHub https://github.com/DenisCarriere/geocoder/issues/102#issuecomment-76551682 .

karanparikh commented 9 years ago

Thanks for the quick response @DenisCarriere. I will try to send out a pull request within the next 2-3 days.

DenisCarriere commented 9 years ago

Well if you want, I can work on it right now.

I'm already in the groove and I've just finished adding Baidu, I can hop over to w3w next.

You could run a few tests and tell me if it works properly.

I should be able to add w3w in about 2-3 hours max

~~

Twitter: @DenisCarriere GitHub: DenisCarriere

On Sat, Feb 28, 2015 at 5:30 PM, Karan Parikh notifications@github.com wrote:

Thanks for the quick response @DenisCarriere https://github.com/DenisCarriere. I will try to send out a pull request within the next 2-3 days.

— Reply to this email directly or view it on GitHub https://github.com/DenisCarriere/geocoder/issues/102#issuecomment-76552515 .

karanparikh commented 9 years ago

Hi @DenisCarriere there is no hurry from my side. I thought it would be a cool feature to add which is why I volunteered to contribute.

DenisCarriere commented 9 years ago

Thanks Karan, adding new providers can be a bit tricky, but once they are added it's easy to maintain. If you could test what3words and make sure it works properly that would be a huge help! :)

DenisCarriere commented 9 years ago

You want to check out the docs and test out w3w:

https://geocoder.readthedocs.org/en/latest/providers/W3W/