search

DenisD3D / Mc2Discord

Link your Minecraft server chat with your Discord (75k downloads)
https://modrinth.com/mod/mc2discord
Apache License 2.0
43 stars 11 forks source link

Current emoji code doesnt support animated emojis. #102

Closed SquirrelKiev closed 3 months ago

SquirrelKiev commented 8 months ago

Describe the bug

image image

Your config file

No response

SquirrelKiev commented 8 months ago

(on the topic of emojis, I don't believe Emojiful supports emojis with capitals in? correct me if i'm wrong but i think the emoji would have to be lowercase'd before being sent into the Minecraft chat in order to be picked up by Emojiful.)

DenisD3D commented 7 months ago

Indeed from you screenshot it appear that the animated format has an additional a. As I'm not a nitro membre I wasn't aware of it. I'm gonna fix this in the next version of the mod

SquirrelKiev commented 7 months ago

if it helps, regex for ANY_DISCORD_MENTION_PATTERN in M2DUtils could be <a?(?::\w+:|@&*|#)\d+>, and line 111's regex in M2DUtils could be <a?:(\w+):\d+> and you'd be pretty much set

SquirrelKiev commented 7 months ago

also, im aware its not the primary topic of the issue report but i still wanna mention it anyway, I don't think Emojiful allows emojis with capitals in? When I tried adding emojis with capitals they simply didn't appear in the emojiful selection, and the official emojiful datapack creation bot in the emojiful Discord also lowercases every emote name. I'm bringing this up here as this means any emotes with capital letters in that are sent in discord chat wont appear correctly in game. Lowercasing the emoji name shows up fine, however. (screenshots are from a fork where the emojis are lowercased before being sent) image image image