search

DenisD3D / Mc2Discord

Link your Minecraft server chat with your Discord (75k downloads)
https://modrinth.com/mod/mc2discord
Apache License 2.0
43 stars 11 forks source link

Crash on advancement #15

Closed Darkere closed 5 years ago

Darkere commented 5 years ago

https://hatebin.com/pklfhoytqo

the player was saying it was the Acquiring Hardware advancement but I don't think that's actually relevant. The game was running fine (with advancements in discord) for days before this.

Note we were still on 1.0.5.

DenisD3D commented 5 years ago

Thanks for reporting. I just launch a server to reproduce this bug and I didn't get any problem with this advancement. Can you describe the step to reproduce and/or send your config file after removing your bot token ? Denis

Darkere commented 5 years ago

ok, so when in testing just now I've found that advancements seem quite a bit buggy on our server for some reason. Was hoping the actual problem would be easily visible but from looking at the code it's not quite that obvious. There have been lot's of advancements without a crash by now so I'm hoping it's just a very rare case. Will be back if it's happens more often :)

Config in case it's still relevant: https://pastebin.com/kehMvLSF

DenisD3D commented 5 years ago

After reading my code again because of issue #16 I notice that I make a bug fix in 1.0.6. Perhaps the bug was coming of that. If you still experience crash in 1.0.5 please update to the last version

IchigoGames commented 5 years ago

Still happening in 1.0.6

IchigoGames commented 5 years ago

https://pastebin.com/buUrezE5 java.lang.NullPointerException: Ticking entity at ml.denis3d.minecraft2discord.BotEvents.onAdvancement(BotEvents.java:103) ~[?:1.14.4-1.0.6] {}