DenisD3D / Mc2Discord

Link your Minecraft server chat with your Discord (75k downloads)
https://modrinth.com/mod/mc2discord
Apache License 2.0
43 stars 11 forks source link

Custom Emoji comptability #66

Closed h4vok-git closed 1 year ago

h4vok-git commented 2 years ago

I have an issue regarding custom emojis using the Mc2Discord mod whilst using the Emojiful mod I can use all the emojis that the emojiful mod can use ingame and they will also show up in server too (except for the additional emojis that the mod uses but discord doesnt have such as :saluting_face: as discord still uses an older version of twemoji than the mod) However when it comes to custom emojis that can be added to emojiful mod via datapacks they will appear ingame as expected but will not show up in the server via the bot. From my understanding the bot just forwards the plain text that was added from the server and since the normal emojis are part of unicode or discord allows bots to just type up the emoji like normal due to this they are passed through with no issue however custom emojis don't as i think the bot doesn't take into account the custom emoji ID which has to be directly referenced in order for the emoji to show up through a bot (refer to this: https://stackoverflow.com/questions/51982806/how-do-i-make-my-discord-py-bot-use-custom-emoji).

You can see the steps to reproduce this from the following screenshots: using normal emoji: works both ways also works if i post an emoji ingame it will appear in server and if i post emoji in server it will appear ingame. image image image image image

using custom emoji i added via datapack: (additional info on adding custom emoji on emojiful mod page https://www.curseforge.com/minecraft/mc-mods/emojiful)

posting custom emoji in discord: as can been seen i can see the emoji in game when i post it through discord image image image

posting custom emoji in game: as can been seen i can see the emoji in game but the emoji doesnt show up in discord

image image image

steps to reproduce:

I know this is a very niche issue and the solution may be more complex than just checking for the emoji ID for custom emojis but i would really appreciate if you could fix this if you would like any additional information msg me on discord: H4VØK#9955

emojiful source code: https://github.com/InnovativeOnlineIndustries/Emojiful

versions: mc2discord-forge-1.16.x-3.2.10 emojiful-1.16.4-2.1.4 forge 36.2.20 (1.16.5)

DenisD3D commented 2 years ago

Will look into it

DenisD3D commented 1 year ago

Added in 3.3.0