DenizenScript / Denizen

NPC and general Spigot scripting, using the Denizen Scripting Language!
https://denizenscript.com/
MIT License
216 stars 106 forks source link

Add offthread_repeat arg to relative teleport command #2533

Closed mergu closed 1 year ago

mergu commented 1 year ago

Tested and results posted in discord https://discord.com/channels/315163488085475337/1148788161565163541/1148788161565163541

Not pictured in videos is specifying the list of relative axes, it defaults to all. When a flag is not set, the packet expects a full location in the world. When a flag is set, it turns it into a relative delta.

I didn't impl yaw/pitch - while it might be nice to have them, I had a feeling it would lead to problems where you unintentionally lose the yaw/pitch by doing things like .center. These can be offthreaded via the look command if someone needs both

This is 5am so please let me know if I did any weird stuff in this PR

mergu commented 1 year ago

Hold off on merging this, I am working on some extra args to also offthread yaw and pitch in the same command (with different logic than the look command's).

mergu commented 1 year ago

Pushed up the addition. I included these as new optional args because it made more sense from a user perspective to default relative yaw/pitch to not move so the player can freely move their head. Ready for review, testing shown here - https://discord.com/channels/315163488085475337/351925110866968576/1150215390434177135