DenizenScript / Denizen

NPC and general Spigot scripting, using the Denizen Scripting Language!
https://denizenscript.com/
MIT License
216 stars 106 forks source link

Include boat types to `EntityTag.color` #2539

Closed BreadcrumbIsTaken closed 1 year ago

BreadcrumbIsTaken commented 1 year ago

Include boat types to EntityTag.color and deprecate EntityTag.boat_type for 1.19+

Changes:

Tested on versions 1.17 - 1.20

Requested by Udnek

Update boat_type for 1.19 and 1.20

Updates the boat_type mechanism to use the new Spigot API for 1.19 and 1.20. Also updates to the new Property registration.

Note: I tried using if checks for the different versions but when I tested on 1.18 it did not like when Boat.Type.class was present anywhere so I decided to put it into the NMS entity helper. I tried messing with the if checks to see what will work but couldn't figure anything out. Let me know if there is a way to do it without needing to add functions to the helper :)

BreadcrumbIsTaken commented 1 year ago

Updated everything. Ready for review.

BreadcrumbIsTaken commented 1 year ago

Done

BreadcrumbIsTaken commented 1 year ago

Should be done.

BreadcrumbIsTaken commented 1 year ago

Done