Fix Advancement handling - Githubissues

DenizenScript / Denizen

NPC and general Spigot scripting, using the Denizen Scripting Language!

https://denizenscript.com/

MIT License

216 stars 106 forks source link

Fix Advancement handling #2578

Closed tal5 closed 11 months ago

tal5 commented 11 months ago

Changes

Removed unused ReflectionMappingsInfo fields (mainly for advancements and also a few other ones along the way).
Minor code cleanups in AdvancementHelperImpl(1.20) - X#of methods, <> where needed, etc.
Renamed AdvancementHelperImpl(1.20)#getAdvancementDataWorld to getNMSAdvancementManager.
Fixed advancement registration/un-registration logic.
Removed some unused logic from AdvancementHelperImpl(1.20)#grantPartial.

Additions

PacketHelperImpl(1.20)#broadcast - util to send the entire server a packet.

Notes

I've based this off of vanilla logic and logic Paper uses for their similar API, but I don't have the deepest understanding of how Denizen's advancement stuff works - so while I've obviously tested it carefully, probably a good idea to give it a bit of testing time before putting a release build out or anything.