Spigot's BlockPlaceEvent actually fires after the block is already placed, and sets it back to the previous state if it's been cancelled.
Changes
Removed BlockHelper#generateBlockState and related reflection, as it's no longer needed.
Changed handleLocation block place event logic to match Spigot behavior - set the block, fire the event, set the block back if cancelled.
handleLocation used to generate a block state with the BlockData of the material being placed in, but that BlockState is meant to be the BlockState that got replaced; it now just gets the state from the block using normal Spigot API instead of using BlockHelper#generateBlockState.
handleLocation's block place event used to create a new ItemTag and get the item used to place the block from that, but that was a bit redundant, so changed to just new ItemStack(...).
Removed the ScriptEntry#dbCallShouldDebug check in the event firing logic, as Debug#echoDebug seems to have that built-in.
Additions
ModifyBlockCommand#callEvent - util to fire an event and return whether it's cancelled.
Reported on Discord.
Description
Spigot's
BlockPlaceEventactually fires after the block is already placed, and sets it back to the previous state if it's been cancelled.Changes
BlockHelper#generateBlockStateand related reflection, as it's no longer needed.handleLocationblock place event logic to match Spigot behavior - set the block, fire the event, set the block back if cancelled.handleLocationused to generate a block state with theBlockDataof the material being placed in, but thatBlockStateis meant to be theBlockStatethat got replaced; it now just gets the state from the block using normal Spigot API instead of usingBlockHelper#generateBlockState.handleLocation's block place event used to create a newItemTagand get the item used to place the block from that, but that was a bit redundant, so changed to justnew ItemStack(...).ScriptEntry#dbCallShouldDebugcheck in the event firing logic, asDebug#echoDebugseems to have that built-in.Additions
ModifyBlockCommand#callEvent- util to fire an event and return whether it's cancelled.