Closed tal5 closed 10 months ago
Might be a good idea to add a EntityTag#mirrorBukkitEntity style method that automatically calls #getDenizenObject? that way entity -> new EntityTag(entity).getDenizenObject() could be EntityTag::mirrorBukkitEntity and be a little cleaner.
yeah that'd be good to have
Might be a good idea to add a EntityTag#mirrorBukkitEntity style method that automatically calls #getDenizenObject? that way entity -> new EntityTag(entity).getDenizenObject() could be EntityTag::mirrorBukkitEntity and be a little cleaner.
yeah that'd be good to have
Added EntityTag#mirrorBukkitEntity
.
Reported on Discord.
Changes
AreaContainmentObject#areaBaseAdvancedMatches
now usesMatchHelper#doesMatch(String, ExactChecker)
, to be consistent with other object types and allow matchers like*_area|area_flagged:thing
.AreaContainmentObject
now extendsFlaggableObject
directly instead of extendingObjectTag
and having unsafe casts toFlaggableObject
.AreaContainmentObject
is aFlaggableObject
, it now usesAbstractFlagTracker#registerFlagHandlers
in it'sregister
method instead of every impl having to specify that seperatleyAreaObject.players
now uses theListTag
filter convertor constructor, and now uses thePlayerTag
constructor directly instead ofmirrorBukkitPlayer
(as the player's are definitely not null).AreaObject.living_entities
now uses theListTag
filter convertor constructor.AreaObject.is_within
now usesinstanceof
pattern matching.AreaObject.is_within
now directly usesWorld#equals
instead ofString#equalsIgnoreCase
on their names (World#equals
compares the world's UUIDs).CuboidTag boundary
variable fromAreaObject.approximate_overlap_areas
in favor of callingarea.getCuboidBoundary()
in-line.AreaContainmentObject
implementations now just extendAreaContainmentObject
instead of separately extendingObjectTag
andFlaggableObject
- let me know if that was there just for clarity and should be reverted, but imo it's pretty clear withAreaContainmentObject
's naming & being able to just hover over it and all.