DenizenScript / Denizen

NPC and general Spigot scripting, using the Denizen Scripting Language!
https://denizenscript.com/
MIT License
213 stars 106 forks source link

`playeffect`: legacy names handling #2629

Closed tal5 closed 4 months ago

tal5 commented 4 months ago

Changes

Additions

[!NOTE] Was thinking about going with a FutureWarning, but seeing as it's something that's already removed (and only really still exists in Spigot's bytecode rewriting and a few specific back-supported methods), thought I'd be best to properly show a warning already and let people start updating.

[!NOTE] random seems to have some issues (e.g. it picking a particle type that requires data and erroring), and also a hard-coded list of visible particles isn't great - honestly I'd say either just deprecate it, or at least replace the visible particles thing with a "particles without data" list.

[!NOTE] 1.17 was the only version with a ParticleHelper impl, but as far as I could see it didn't do anything? it checked for MaterialData, but nothing ever passes a MaterialData to that method.