Replaced the ParticleHelper NMS module with a single LegacyParticleNaming util, as there's no need for it to be a module anymore.
playeffect now has a LegacyNamingHelper for the Particle enum.
ParticleHelper's "visible particles" list is now managed in playeffect, as that's the only place it's used.
Removed the Denizen Particle wrapper as it wasn't really needed anymore, and replaced relevant usages with direct API usage.
Additions
oldSpigotNamesVerySlowWarning - general warning for using old Spigot names instead of Minecraft names.
LegacyNamingHelper util for stuff that used to take the old Spigot names and need back-support + a warning.
LegacyParticleNaming - the extra Spigot-esque particle naming ParticleHelper had.
[!NOTE]
Was thinking about going with a FutureWarning, but seeing as it's something that's already removed (and only really still exists in Spigot's bytecode rewriting and a few specific back-supported methods), thought I'd be best to properly show a warning already and let people start updating.
[!NOTE]
random seems to have some issues (e.g. it picking a particle type that requires data and erroring), and also a hard-coded list of visible particles isn't great - honestly I'd say either just deprecate it, or at least replace the visible particles thing with a "particles without data" list.
[!NOTE]
1.17 was the only version with a ParticleHelper impl, but as far as I could see it didn't do anything? it checked for MaterialData, but nothing ever passes a MaterialData to that method.
Changes
ParticleHelper
NMS module with a singleLegacyParticleNaming
util, as there's no need for it to be a module anymore.playeffect
now has aLegacyNamingHelper
for theParticle
enum.ParticleHelper
's "visible particles" list is now managed inplayeffect
, as that's the only place it's used.Particle
wrapper as it wasn't really needed anymore, and replaced relevant usages with direct API usage.Additions
oldSpigotNames
VerySlowWarning
- general warning for using old Spigot names instead of Minecraft names.LegacyNamingHelper
util for stuff that used to take the old Spigot names and need back-support + a warning.LegacyParticleNaming
- the extra Spigot-esque particle namingParticleHelper
had.