Biomes: proper key handling with `NamespacedKey` - Githubissues

DenizenScript / Denizen

NPC and general Spigot scripting, using the Denizen Scripting Language!

https://denizenscript.com/

MIT License

216 stars 106 forks source link

Biomes: proper key handling with `NamespacedKey` #2651

Closed tal5 closed 1 month ago

tal5 commented 1 month ago

Reported on Discord.

Changes

BiomeNMS now stores a NamespacedKey key instead of a String name, for proper biome key handling/parsing.
BiomeNMS#getName has been replaced by getKey.
All relevant places changed to take/use NamespacedKeys instead of Strings, with Utilities#namespacedKeyToString to stringify where needed & CraftNamespacedKey for NMS conversions.

[!NOTE] Might be a good idea to have a cache of Utilities#namespacedKeyToString on BiomeNMS, just because it's used a bunch to get the "display name"? it's not a particularly heavy operation or anything though, so lmk what do you think.

mcmonkey4eva commented 1 month ago

cache wouldn't hurt but yeah it's a tenth of a nanosecond difference