search

DenizenScript / Depenizen

Addon to Denizen that provides script support for other major plugins.
MIT License
60 stars 44 forks source link

BreweryX (v3.2.0+) Support #430

Open Jsinco opened 4 months ago

Jsinco commented 4 months ago

Many many months ago in the Denizen Discord, I wanted to figure out how to start the execution of a script from another plugin so I could include Denizen support in BreweryX. After the discussion I decided to implement BreweryX into Depenizen instead. Everything should be compatible starting with release 3.2.0 of BreweryX (which I plan to release soon after this pull request). Hopefully there isn't much I need to change here, I'm a first-time contributer but I did my best to follow the style of other plugin bridges.

BreweryX Github: https://github.com/Jsinco/BreweryX Spigot page: https://www.spigotmc.org/resources/breweryx.114777/

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

Jsinco commented 4 months ago

I fixed a bunch of the commented issues. Not sure if I got everything 100% but just let me know what needs to be fixed and I'll get on it!

Jsinco commented 4 months ago

Fixed the new issues

Jsinco commented 4 months ago

Changed

szarkans commented 4 months ago

Please approve this, i need Depenizen x BreweryX ASAP!

Jsinco commented 2 months ago

Been a bit. Any updates on this?