search

Dennis-van-Gils / python-dvg-pyqtgraph-threadsafe

PyQtGraph library providing thread-safe plot curves with underlying (ring) buffers: HistoryChartCurve, BufferedPlotCurve & PlotCurve.
https://pypi.org/project/dvg-pyqtgraph-threadsafe/
MIT License
9 stars 7 forks source link

support both pyside and pyqt #2

Closed mvgorcum closed 2 years ago

mvgorcum commented 2 years ago

This is basically a copy of what pyqtgraph does to support both pyside and pyqt. Let me know if this is acceptable to you.

Ps. Hoi Dennis! Leuke library.

Dennis-van-Gils commented 2 years ago

Thanks Mathijs. I'll have a closer look in the coming month. I need to be sure nothing breaks in the other projects that rely on this library. It is used, among other things, for a practicum at the UT where I locked the python version to 3.8. But adding support for PySide sounds like a good plan.

mvgorcum commented 2 years ago

Hi Dennis,

Any update on this? I'm considering using this in production so if it doesn't fit with your project I'll probably maintain a fork and upload that to pypi, but I'd of course be happier to just upstream these small changes.

Dennis-van-Gils commented 2 years ago

Hi Mathijs, I'll go into it straight away.

On 12-Sep-22 22:53, Mathijs van Gorcum wrote:

Hi Dennis,

Any update on this? I'm considering using this in production so if it doesn't fit with your project I'll probably maintain a fork and upload that to pypi, but I'd of course be happier to just upstream these small changes.

— Reply to this email directly, view it on GitHub https://github.com/Dennis-van-Gils/python-dvg-pyqtgraph-threadsafe/pull/2#issuecomment-1244453067, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI4JUI5YPNO66BS422MADLLV56J4RANCNFSM54E4K64A. You are receiving this because you commented.Message ID: @.***>

Dennis-van-Gils commented 2 years ago

One thing puzzles me. Why do you assign the variables QtCore, QtGui and QtWid to themselves again?

Dennis-van-Gils commented 2 years ago

Hi Mathijs. I have finished adding support for PyQt5, PyQt6, PySide2 and PySide6. Your pull request was a very handy basis, but a few more changes had to be made in other parts of the code as well. They involve the use of Qt enumerations and app.exec(), see https://www.pythonguis.com/faq/pyqt5-vs-pyqt6/. All Qt libraries are tested in Python 3.9 and work fine. I'm closing the pull without merging. Thanks again.

mvgorcum commented 2 years ago

Thanks for taking the time to go through it!