search

DennisBauer / RecurringExpenseTracker

A Material You recurring expense tracker, allowing you to keep track of your monthly spending.
GNU General Public License v3.0
102 stars 15 forks source link

Add icon to first payment date picker #204

Closed r1n1os closed 5 months ago

r1n1os commented 5 months ago

From the bottom sheet to add expense or upcoming payment I have edited the First Payment Field to be more obviouse to the user that is a date picker. As user might expecting that is a TextField as the above fields.

Also, I have change the hint value of that string from all string.xml resourses to be more descriptive based on the actual functionality. As the E.g Today as user I would expect to be able to write something. Or even with Picker I would expect to see Today or Tomorrow and for the future dates to be the actual formatted date.

Before:

After:

DennisBauer commented 5 months ago

Thanks for the PR! I like the change itself and will approve it after you've applied the following change: Please do not change the string in all language files as this will prevent it from being translated to the local language. If you change a string in English and do not know the translation into a local language, just delete it for the other languages. This will use the default English string as fallback until the translation for that string is added back.

r1n1os commented 5 months ago

I have done the change. I have removed the text I have changed from the other translation files

DennisBauer commented 5 months ago

Please look into the pipeline issues. You need to fix some formatting issues. You can easily resolve most of them by just running the ktlintFormat task in Android Studio or in the command line:

./gradlew ktlintFormat
r1n1os commented 5 months ago

I have used the command and I noticed that indeed a change happen on the line where the issue was. If there is still an issue can you please explain to me how to identify if there are issues before I push the changes. To be sure that everything is fine

DennisBauer commented 5 months ago

To verify the formatting of the code the CI pipeline executes the following command, which you can also do locally:

./gradlew ktlintCheck

To fix most of the issues you can run the ktlintFormat task. For the remaining once you need to look into the error message and follow the instructions.

DennisBauer commented 5 months ago

For the next time please submit the PR from a feature branch in your fork instead of the main branch.