search

DennisOSRM / hms-mqtt-publisher

HMS-XXXXW-2T MQTT publisher and Home Assistant addon
BSD 2-Clause "Simplified" License
117 stars 16 forks source link

Implement output channels #34

Closed DennisOSRM closed 11 months ago

DennisOSRM commented 11 months ago

This PR is an experimental implementation of output channels as defined in a config.toml file that allow publishing inverter state to more that one target.

DennisOSRM commented 11 months ago

Waiting on #27

DennisOSRM commented 11 months ago

@dominikandreas would you mind giving the Dockerfile and the ha add-on a test drive? They should just work, but I don't have the facility to test. Thanks so much.

dominikandreas commented 11 months ago

Since I had already addressed the comments above while testing, I created a PR for this: https://github.com/DennisOSRM/hms-mqtt-publisher/pull/37

Hope I didn't make a mistake anywhere, was a bit hasty.

dominikandreas commented 11 months ago

With the changes from my PR, everything seems to work as expected 👍

DennisOSRM commented 11 months ago

Thanks so much for the thorough review. Your suggestion have been implemented in commit 9f6ffdb.

DennisOSRM commented 11 months ago

resolves #7, resolves #14, resolves #25