DennisOSRM / hms-mqtt-publisher

HMS-XXXXW-2T MQTT publisher and Home Assistant addon
BSD 2-Clause "Simplified" License
117 stars 16 forks source link

Improve error handling, Nightly build #44

Closed dominikandreas closed 10 months ago

dominikandreas commented 11 months ago

This PR includes the following updates:

It should've probably been separate PRs, but I haven't had the time yet to separate the work into multiple branches. I can do that over the next couple of days if necessary, but wanted to open the PR already to get some feedback.

DennisOSRM commented 11 months ago

Nice! I guess the build/push to docker hub will 'just work'™️ once the PR is merged, or does it require additional changes in configuration?

dominikandreas commented 11 months ago

For the nightly build you still need to define the DOCKER_HUB_REPOSITORY_NIGHTLY secret in the repository settings. I think then it should work after the merge.

Still need to

DennisOSRM commented 11 months ago

Ah, right. I'll put that secret in tomorrow.

dominikandreas commented 11 months ago

thx for the collaboration invite :-) everything seems to be working in the addon so far, but I'll test again tomorrow when the sun is up

dominikandreas commented 11 months ago

Screenshot_20231201-125927 I am getting updates from the inverter in home assistant, but there are still messages about failures to publish. Also the addon seems to have reported the same values over a couple of hours today until I restarted it. I think we have to decrease the frequency of queries to the inverter

DennisOSRM commented 11 months ago

Did you try with the latest changes from yesterday? It will try to deliver three times before it gives up. Also, requesting data more often than every 30.5 seconds will prohibit the inverter from updating. Then the data stays the same.

DennisOSRM commented 11 months ago

For the nightly build you still need to define the DOCKER_HUB_REPOSITORY_NIGHTLY secret in the repository settings. I think then it should work after the merge.

Still need to

Added DOCKER_HUB_REPOSITORY_NIGHTLY to point to https://hub.docker.com/repository/docker/dennisosrm/hms-mqtt-publisher-nightly/general

dominikandreas commented 11 months ago

Haven't been able to spend any time on this, I'll probably do some more testing tomorrow

DennisOSRM commented 11 months ago

Sounds good. Thanks for the heads up.

dominikandreas commented 10 months ago

Looks good now! I've updated the nightly addon as well as the main one (after testing the nightly version) to the latest build from main.

I've also fixed the workflow files, the builds were failing because it couldn't access the GIT_HASH. I think the nightly workflow is still failing because it can't access the secrets before it's merged.

I think the PR should be ready to be merged now.

DennisOSRM commented 10 months ago

Cool. Then let's get it in!

DennisOSRM commented 10 months ago

Thanks so much for the great work.

DennisOSRM commented 10 months ago

Just realized that the nightly build is also run on PRs. I am not sure we'd want that. What do you think?

dominikandreas commented 10 months ago

I think it's actually quite useful to see if a PR builds successfully and it also allows to quickly reference a build in docker hub for local testing in the home assistant addon.

Btw the branch name is added to the tag, so there's no conflict with the main builds

DennisOSRM commented 10 months ago

perfect. then that's more than fine. 😀