Closed dominikandreas closed 10 months ago
Nice! I guess the build/push to docker hub will 'just work'™️ once the PR is merged, or does it require additional changes in configuration?
For the nightly build you still need to define the DOCKER_HUB_REPOSITORY_NIGHTLY
secret in the repository settings. I think then it should work after the merge.
Still need to
Ah, right. I'll put that secret in tomorrow.
thx for the collaboration invite :-) everything seems to be working in the addon so far, but I'll test again tomorrow when the sun is up
I am getting updates from the inverter in home assistant, but there are still messages about failures to publish. Also the addon seems to have reported the same values over a couple of hours today until I restarted it. I think we have to decrease the frequency of queries to the inverter
Did you try with the latest changes from yesterday? It will try to deliver three times before it gives up. Also, requesting data more often than every 30.5 seconds will prohibit the inverter from updating. Then the data stays the same.
For the nightly build you still need to define the
DOCKER_HUB_REPOSITORY_NIGHTLY
secret in the repository settings. I think then it should work after the merge.Still need to
Added DOCKER_HUB_REPOSITORY_NIGHTLY to point to https://hub.docker.com/repository/docker/dennisosrm/hms-mqtt-publisher-nightly/general
Haven't been able to spend any time on this, I'll probably do some more testing tomorrow
Sounds good. Thanks for the heads up.
Looks good now! I've updated the nightly addon as well as the main one (after testing the nightly version) to the latest build from main.
I've also fixed the workflow files, the builds were failing because it couldn't access the GIT_HASH. I think the nightly workflow is still failing because it can't access the secrets before it's merged.
I think the PR should be ready to be merged now.
Cool. Then let's get it in!
Thanks so much for the great work.
Just realized that the nightly build is also run on PRs. I am not sure we'd want that. What do you think?
I think it's actually quite useful to see if a PR builds successfully and it also allows to quickly reference a build in docker hub for local testing in the home assistant addon.
Btw the branch name is added to the tag, so there's no conflict with the main builds
perfect. then that's more than fine. 😀
cargo clippy
and fix all issuescargo fmt
to format all source filesThis PR includes the following updates:
--debug_logging
parameter and corresponding option in Home Assistanttry_publish
instead ofpublish
to propagate MQTT connection errorsIt should've probably been separate PRs, but I haven't had the time yet to separate the work into multiple branches. I can do that over the next couple of days if necessary, but wanted to open the PR already to get some feedback.