DennisOSRM / hms-mqtt-publisher

HMS-XXXXW-2T MQTT publisher and Home Assistant addon
BSD 2-Clause "Simplified" License
111 stars 16 forks source link

Fix oder of magnitude reported for current in HA plugin #86

Closed DennisOSRM closed 7 months ago

DennisOSRM commented 7 months ago

fixes #85

dominikandreas commented 7 months ago

I think the simple MQTT publish service has the same issue: https://github.com/DennisOSRM/hms-mqtt-publisher/blob/main/hms2mqtt/src/simple_mqtt.rs#L43 Maybe we should fix it in the same PR as well.

DennisOSRM commented 7 months ago

This seems to be the correct order of magnitude. Or am I seeing this wrong?

dominikandreas commented 7 months ago

Oh, yes my mistake. Documentation in https://github.com/DennisOSRM/hms-mqtt-publisher/blob/main/hms2mqtt/src/protos/RealData.proto#L29 is wrong then

dominikandreas commented 7 months ago

Once the new release is there I will update the home assistant addon. Thanks for the fix

DennisOSRM commented 7 months ago

Oh, good catch! Will amend the PR later today and put out a release in the evening.