DennisRSI / AdminBrokerClientAgentPortal

For Admins Brokers Clients and Agents
3 stars 0 forks source link

QA: Commission Report by all brokers fails #198

Closed patricksheedy closed 5 years ago

patricksheedy commented 5 years ago

Repro:

  1. Login as Admin.
  2. Go to commission report
  3. Run report by all brokers.
  4. Check chrome console. Error occurred when making REST call.
patricksheedy commented 5 years ago

This is due to a divide by zero error on line 352 in this proc: ReportCommissionByBroker

Asking Dennis for clarification on how to fix this.

patricksheedy commented 5 years ago

SQL repro for this issue: DECLARE @TotalCount int EXECUTE [dbo].[ReportCommissionByBroker] 45 -- @BrokerId ,null ,null ,'1/18/2018' -- @CheckInDate ,'1/18/2019' -- @CheckOutDate ,'All' -- @PaidStatus ,0 -- @StartRowIndex ,30000 -- @NumberOfRows ,@TotalCount OUTPUT go

patricksheedy commented 5 years ago

This is no longer occurring on QA.