search

DennisRas / AlterEgo

AlterEgo is a World of Warcraft addon to track the Mythic+ progress of all your characters
11 stars 7 forks source link

Feature: Show in addon compartment #106

Closed Wolkenschutz closed 8 months ago

Wolkenschutz commented 8 months ago

Hello Dennis,

Your addon is exactly what I was looking for - thank you very much for it!

However, I have a suggestion regarding minimap buttons. I don't like them. If I hide your minimap button now, the access for me is significantly impaired, as I also don't like slash commands.

My suggestion: Integrate your addon into WoW's addon compartment! You already have all the prerequisites since you are using the DBIcon-Lib.

I've done that myself. Maybe you'll like it. :)

Best regards, Shantalya

DennisRas commented 8 months ago

Hi @Wolkenschutz :)

That's a great suggestion and I appreciate the work and research you've done.
Like you said, it looks like a simple thing to add considering I'm already using LDB and LDBIcon, so why not (and should be the standard by all addons actually).

There are two things I'd like to talk about:

  1. LDBIcon:AddButtonToCompartment should be used on addon initialization well or it will only be added to the compartment when changing the setting (I assume, unless LDBIcon saves the state for that)
  2. I don't think it needs to be a setting actually. It could just be added to the compartment during addon initialization as the compartment doesn't hurt anyone's UI/UX by default, if that makes sense (and people can just hide the minimap button then).
Wolkenschutz commented 8 months ago

Your response was quick!

To your questions: I took this approach because, unfortunately, some people don't like WoW's addon compartment (yes, it happens). This way, everyone is happy. :)

Otherwise, simply use LDBIcon:AddButtonToCompartment during initialization, and it will persist forever.

If I misunderstood your question: showInCompartment is recognized by LDBIcon automatically, and it adds it or not. So, it's not necessary to add anything during initialization if you want it as a setting, as I did.

DennisRas commented 8 months ago

Your response was quick!

To your questions: I took this approach because, unfortunately, some people don't like WoW's addon compartment (yes, it happens). This way, everyone is happy. :)

Otherwise, simply use LDBIcon:AddButtonToCompartment during initialization, and it will persist forever.

If I misunderstood your question: showInCompartment is recognized by LDBIcon automatically, and it adds it or not. So, it's not necessary to add anything during initialization if you want it as a setting, as I did.

Nah you are spot on :-)
I haven't looked into all of this yet. I figured LDBIcon probably would save the state on its own (or read the provided state like you mentioned).

In regards to the preference of some users, I think adding the addon the compartment wouldn't hurt either group of users; The players not using the compartment wouldn't see it anyway, and the players using the compartment will have the same option to hide/show the minimap on its own. Does that make sense?

So to clarify, how about we just add the showInCompartment configuration by default and players still have the option to show/hide the minimap as usual.

DennisRas commented 8 months ago

@Wolkenschutz Hi again. Mind if I credit you in the changelog for the suggestion of adding the addon to the compartment? I'll just mention your Github name (and profile link?) unless you have a diff. name to use.

Wolkenschutz commented 8 months ago

That's okay, yes. And thanks again! :)