search

DennisRas / AlterEgo

AlterEgo is a World of Warcraft addon to track the Mythic+ progress of all your characters
11 stars 7 forks source link

Track Bullion as currency #161

Closed Numynum closed 4 months ago

Numynum commented 4 months ago

seems to fulfil #160, didn't test what happens on weekly reset though, too lazy 😜

Numynum commented 4 months ago

image seems to be working at least 👌

DennisRas commented 4 months ago

Hey @Numynum champ :) Appreciate it. Been really busy last month.

Could we merge this into dev instead of main? Main is protected for releases only. Also I was thinking instead of checking for the dinar currencyType, we could just have the condition based on itemID being set for that currency:

      if dataCurrency.itemID ~= nil then
        currency.quantity = C_Item.GetItemCount(dataCurrency.itemID, true)
        currency.iconFileID = C_Item.GetItemIconByID(dataCurrency.itemID) or 0
      end

Also added a 0 as default for iconFileID as it wants an integer and GetItemIconByID may return nil. Could you make the above changes and update the PR? Then I'll pull it in and add your name as credit in the changelog for the next update.

Numynum commented 4 months ago

changes have been made 👍 I'm not bothered about credit 🙂