search

DennisRas / WeeklyKnowledge

Track your profession knowledge across your characters
https://www.curseforge.com/wow/addons/weeklyknowledge
7 stars 1 forks source link

Micro stuttering #57

Open DennisRas opened 1 month ago

DennisRas commented 1 month ago

From CurseForge:

Since the last update I have some serious microstuttering in the game. It's disabling the addon and going smooth as butter. Does it happen to anyone else?

emptyrivers commented 3 weeks ago

Hey there. In my unending quest to be able to play this game without performance problems, I did identify the source of this micro-stutter. Specifically,WeeklyKnowledge.Core:Render() takes about 50,000 microseconds to execute: Core:Render() cpu That's more than long enough to notice, and it happens fairly frequently - pretty much anytime you loot anything, there's a noticeable hitch due to WeeklyKnowledge re-rendering its displays, even if they're not currently visible (skinning is especially intolerable, given the frequency of events that trigger Render during that activity) Monkeypatching the addon such that WeeklyKnowledge.Main:Render() and WeeklyKnowledge.Checklist:Render() return ASAP if their respective frames are not visible subjectively eliminated the stutters (while the windows aren't visible, of course).

In particular, the main window seems to be the biggest hog, so if you're looking for a good target for optimization, I think you would do well to start with that.

emptyrivers commented 3 weeks ago

Oh, I should clarify - that's 50,000 microseconds to render, when there are 13 characters recorded in the SavedVariables, 9 of which have 2 professions each for a total of 18 rows in the Main window display. I suspect that the actual time to execute rendering will vary depending on the # of rows displayed.

DennisRas commented 1 week ago

Thanks for the feedback @emptyrivers We already talked on Discord earlier, but wanted to report here that I'm looking into the issue asap.