DennisSnijder / MakeGithubGreatAgain

Extension for making GitHub great again
https://chrome.google.com/webstore/detail/makegithubgreatagain/gpejlkhibgecggplgogpbgbdpnhogmhk
1.05k stars 49 forks source link

Colors are weird #56

Closed tyliec closed 7 years ago

tyliec commented 7 years ago

Looks like Github changed their styling

tyliec commented 7 years ago

https://gyazo.com/1e1c1f8302f5c732f99c99bc36fc7c5c

bntzio commented 7 years ago

Yeah this is happening to me as well, looks like Github changed its css.

bntzio commented 7 years ago

Just dropped in a pull request to fix this (#57) 👍 @Viltaria @DennisSnijder

tyliec commented 7 years ago

The hero we need! @bntzio

bntzio commented 7 years ago

If someone needs to fix the issue before @DennisSnijder do the merge you guys can download my fork and go to chrome://extensions then click Load unpacked extension and select the fork folder.

Here's the fork 👉 https://github.com/bntzio/MakeGithubGreatAgain

PuKoren commented 7 years ago

Thanks @bntzio it is working fine. However I have a small display issue on the Pull Request/Issues views:

pull requests

As you can see its not very readable. Maybe something else changed with the latest GitHub update? I don't recall exactly how it was before the update.

bntzio commented 7 years ago

@PuKoren Are you using some chrome extension to change the GitHub layout apart from MakeGithubGreatAgain?

I can see a ToDo link in the screenshot. Maybe that's the styling conflict.

PuKoren commented 7 years ago

True, I use ZenHub. I just tried to disable it and still see the white color when on Pull Requests / Issues views.

You don't have the same issue?

bntzio commented 7 years ago

Nope, have u tried closing your browser and re-opening? or maybe delete the cache

PuKoren commented 7 years ago

Ok then I guess you are right, thanks (tried what you mentioned but with no luck, I guess there is something well hidden inside my chromium)

bntzio commented 7 years ago

I suggest you download Chrome Canary, install the extension manually again and go to https://github.com again to see if it solves the issue, if yes, then there's a conflicting extension messing with MakeGithubGreatAgain in your normal Chrome browser.

DennisSnijder commented 7 years ago

Should be fixed now thanks to #62