DennisSnijder / bolt-ui-options

Provides options with a simple UI
8 stars 3 forks source link

Fixes for Bolt 3.3+ #12

Closed GwendolenLynch closed 7 years ago

GwendolenLynch commented 7 years ago

Upcoming changes show some problems that are hopefully all caught in this PR.

Right now in release/3.3 the early invocation of services to build the controller object causes a fatal loop.

This PR:

Ideally the boot() should go too, and you just pass what you need to the helper functions. But your call down the track :smile:

DennisSnijder commented 7 years ago

Thanks 👍

GwendolenLynch commented 7 years ago

Oh, and sorry, I meant the before() is the one you really want to think about, but again over to you.