search

DennisSuitters / summernote-image-attributes

Summernote plugin to edit image attributes
MIT License
89 stars 89 forks source link

Change image src if modified #32

Closed pmosse closed 6 years ago

DennisSuitters commented 6 years ago

Line 199 if(imgInfo.src)$img.attr('src',imgInfo.src);else$img.attr('src', '#'); should be setting the image src. Was this not the case for you?

DennisSuitters commented 6 years ago

This PR actually would conflict now, as I've gone through a lot of the code to check for errors. I've also added Travis to the repo. Let me know if the problem persists and I'll manually add your changes, or you can close this PR and create a new one with the changes you want to make.

pmosse commented 6 years ago

Hey @DiemenDesign, it was not working for me previously but now with the last version it is working fine, so we could close this PR. Thank you!

DennisSuitters commented 6 years ago

No worries, glad it was resolved for you. Your PR did give clues to the issue.