search

DennisSuitters / summernote-image-attributes

Summernote plugin to edit image attributes
MIT License
89 stars 89 forks source link

tabs style is not working on bootstrap 4 #48

Closed digitaldreams closed 4 years ago

digitaldreams commented 6 years ago

Hi Thanks for your awesome work. I really appreciate your effort. But on thing i notice that tabs style is not working. Can you have a look. I am using Bootstrap 4 tabs style is not working on bootstrap 4

DennisSuitters commented 6 years ago

Will have to check that out.

DennisSuitters commented 5 years ago

The tabs work differently between the different versions of Bootstrap, we may have to separate versions of the plugin, or have an option to set what version of BS is being used so the correct tab layout is used.

DennisSuitters commented 5 years ago

I'm waiting on a response from the Summernote Team if we can add a version or settings test like $.summernote.version; that can return which of the 3 Summernotes is being used like -bs3, -bs4 or -lite, so then plugins can test which Summernote it's being used with so a programmatic control can be used to display the correct markup for that version, seeing as though Bootstrap use of tabs is different between versions.

mobweb commented 5 years ago

As a quick fix for the display issues I made the changes in the attached patch, in case it helps anybody.

image-attributes-bs4-support.patch.zip

DennisSuitters commented 4 years ago

Turns out it was just a simply missing classes in the markup.