DennisWG / Roid-Macros

Vanilla macros on steroids!
MIT License
58 stars 20 forks source link

Added nomod condition. Initial /cancelaura functionality. #54

Closed Moetsukii closed 12 months ago

Moetsukii commented 5 years ago

@DennisWG How do you wanna go about /cancelaura?

An easy way would be to include something like this: GetSpellInfoVanillaDB

To have a mapping between Icon <=> Spell Name.

But it's a 4MB file .....

Moetsukii commented 5 years ago

Note to self:

https://wowwiki.fandom.com/wiki/API_GetPlayerBuff

Has conflicting documentation. Index 1..16 but in the example 0 is used for first index.

pfUI uses CancelPlayerBuff(GetPlayerBuff(-1 + i,"HELPFUL"))

But when I try to use it in combination with UnitBuff("player", i) the Indices don't match when according to API docs they should.

Need to investigate further.

Moetsukii commented 5 years ago

I'm still confused about UnitBuff indexing. It didn't follow any logical indexing rules.

Oh well, it doesn't matter anymore.

Moetsukii commented 5 years ago

@DennisWG I think you can close Issue #33 and #35 now

DennisWG commented 5 years ago

Hey,

thank you once again for contributing! I'm not too sure about this yet, though. I think that it would be confusing to some people to enter the icon's path instead of just the buff's name. Especially since the [no]buff modifier exists and does just that. Have you looked into Roids.HasBuffName and how I get the name there?

Since you've mentioned having troubles with some of the API functions, I've played around with this for a few minutes and got something working. Here's what I've done:

From what I've been able to test so far this seems to work (including invisible GM buffs), but I'm no longer actively playing, so there may be some edge cases that I'm missing.

I think it would be very nice to support buff names, so could you give this a shot yourself and report back to me if this works for your tests as well?

Cheers, Dennis

supernova555 commented 3 years ago

Hello. /cast [nomod] spell doesne't work for me and

showtooltip

What is the right way to use them?