Dentosal / python-sc2

A StarCraft II bot api client library for Python 3
MIT License
586 stars 182 forks source link

Fix kill_switch signal handler #214

Closed islamelnabarawy closed 5 years ago

islamelnabarawy commented 5 years ago

This fixes the signal handler for SIGINT.

The two arguments seem to have been removed in a previous commit, but they are actually necessary for the signal handler to match the expected signature. Without them, python throws a TypeError.

islamelnabarawy commented 5 years ago

@tweakimp I added a comment to explain the unused arguments. Squashing the commits seems to have caused GitHub to lose our earlier conversation, sorry about that.

tweakimp commented 5 years ago

I fixed this in #219 , i had to merge master into dev to start working on it and then fixed this on the way. :)