Implement player name and option for fullscreen windows

Dentosal / python-sc2

A StarCraft II bot api client library for Python 3

MIT License

586 stars 182 forks source link

Implement player name and option for fullscreen windows #225

Closed drakonnan1st closed 5 years ago

drakonnan1st commented 5 years ago

add optional string 'name' to Player (removes LocalPlayer or foo12345)
add option to launch the sc2 window in fullscreen

Example usage:

run_game(maps.get("BlueshiftLE"), [
    Human(Race.Zerg, fullscreen=True, name="Human"),
    Bot(Race.Zerg, WorkerRushBot(), name="WorkerRush")],
         realtime=True)

NOTE: apparently using player_name screws up laddermanager, not sure how

mindme333 commented 5 years ago

it messes up the Ladder Manager because they created their own function to put the bot names into the replays because that ability didn't exist at the time. Will be changed in the future, but isn't seen as a priority. Any bots that go on the ladder should just leave it empty for now.

Dentosal commented 5 years ago

I implemented the name feature by hand before noticing this PR. I'll see if I can check out the per-user-fullscreen soon. Thanks for the PR, anyway.